[neomutt-devel] [PATCH] fix formatting of emails

Alejandro Colomar alx at kernel.org
Fri Sep 15 18:30:36 CEST 2023


Hi Richard,

On 2023-09-15 16:34, Richard Russon wrote:
> Hi Alejandro,
> 
>> Here are some fixes to formatting issues I found in the website.
>> -  Remove spurious space after '<'.
>> -  Add space after '>'.
> 
> Well spotted!
> 
> Unfortunately those are machine-generated files.
> The source is docs/manual.xml in the code repo.
> 
> Fortunately, I've managed to find the right place to apply your fixes.
> 
> Do NOT look here, if you're easily scared :-)
> 
> https://github.com/neomutt/docbook/blob/b616f2208ee9dd00c710b55064a6c77111026398/build#L20-L21

That regex seems wrong.  Did you really intend to write [^ -,:.<]?
That range includes '(', which should have a space before it.

Here's one example where it doesn't work well:

diff --git a/guide/gettingstarted.html b/guide/gettingstarted.html
index cecfa88..8a1ca0a 100644
--- a/guide/gettingstarted.html
+++ b/guide/gettingstarted.html
@@ -1750,7 +1750,7 @@ bind editor <delete> backspace
       <p>In addition to key bindings in
       <a class="xref" href="#tab-key-pager" title="Table 2.10. Most common pager keys">Table 2.10, “Most common pager keys”</a>, many of the functions from the index menu are also available in the pager, such as
       <code class="literal"><delete-message></code> or
-      <code class="literal"><copy-message></code>(this is one advantage over using an external pager to view messages).</p>
+      <code class="literal"><copy-message></code> (this is one advantage over using an external pager to view messages).</p>
       <p>Also, the internal pager supports a couple other advanced features. For one, you can set
       <a class="link" href="reference.html#pager-read-delay" title="3.289. pager_read_delay">$pager_read_delay</a> to operate in a preview mode, where new messages are not marked read unless you remain on the message for a certain length of time. Additionally, it will accept and translate the
       <span class="quote">“<span class="quote">standard</span>”</span> nroff sequences for bold and underline. These sequences are a series of either the letter, backspace (


Cheers,
Alex

> 
> Cheers,
>     FlatCap / Rich

-- 
<http://www.alejandro-colomar.es/>
GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://mailman.neomutt.org/pipermail/neomutt-devel-neomutt.org/attachments/20230915/5942e6ff/attachment.sig>


More information about the neomutt-devel mailing list