[neomutt-devel] [PATCH 2/2] remove unused global variable C_Greeting

[toogley]

The commit introducing the Greeting variable used the modern
ConfigSubset[1] methods, but also added the global variable
C_Greeting[2]. That means we can just remove this global variable.

[1]:
https://github.com/neomutt/neomutt/commit/65841f725ee6069f59da358aa2415467ae493161#diff-b23c85715fbc45850369edbbfad73600e1532e85ab7591f08d75bdf421417a28R693
[2]:
https://github.com/neomutt/neomutt/commit/65841f725ee6069f59da358aa2415467ae493161#diff-6e91c7fbb0a6434f59c9c7d08a2d1ef0c408142708cbe8029ad21694fb9219d3R91
---
 mutt_config.c  | 2 +-
 mutt_globals.h | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/mutt_config.c b/mutt_config.c
index 3105acf33..1851daf56 100644
--- a/mutt_config.c
+++ b/mutt_config.c
@@ -349,7 +349,7 @@ struct ConfigDef MainVars[] = {
   { "gecos_mask", DT_REGEX, &C_GecosMask, IP "^[^,]*", 0, NULL,
     "Regex for parsing GECOS field of /etc/passwd"
   },
-  { "greeting", DT_STRING, &C_Greeting, 0, 0, NULL,
+  { "greeting", DT_STRING, NULL, 0, 0, NULL,
     "Greeting string added to the top of all messages"
   },
   { "header", DT_BOOL, &C_Header, false, 0, NULL,
diff --git a/mutt_globals.h b/mutt_globals.h
index 7e2e3eab5..18c040b71 100644
--- a/mutt_globals.h
+++ b/mutt_globals.h
@@ -88,7 +88,6 @@ WHERE char *C_AttachFormat;                  ///< Config: printf-like format str
 WHERE char *C_ConfigCharset;                 ///< Config: Character set that the config files are in
 WHERE char *C_DateFormat;                    ///< Config: strftime format string for the `%d` expando
 WHERE char *C_Editor;                        ///< Config: External command to use as an email editor
-WHERE char *C_Greeting;                      ///< Config: Greeting string added to the top of all messages
 WHERE char *C_Hostname;                      ///< Config: Fully-qualified domain name of this machine
 WHERE char *C_IndexFormat;                   ///< Config: printf-like format string for the index menu (emails)
 
-- 
2.30.2