[neomutt-devel] Unused functions

Guillaume Brogi gui-gui at netcourrier.com
Sun Mar 12 18:38:07 CET 2017


On Sun, Mar 12, 2017 at 03:33:37PM +0000, Richard Russon wrote:
> I'm starting to tidy the code.
> I've found 8 unused functions and 31 functions that should be static.
> 
> The winner is the prototype for crypt_smime_ask_for_key() which hasn't
> existed for 13 years!
> 
> What should I do with the unused functions?
> 
> - leave them be
> - comment them out
- delete them
> - move them to obsolete.c
> - something else
> 
They're still in the git history if they become needed. Maybe we could
have a delay before we delete them, but anything that hasn't been used
in the past X months should be deleted. But then, we have to check old
unused functions regularly, so I'm all for setting X=0.

-- 
guiniol
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.neomutt.org/pipermail/neomutt-devel-neomutt.org/attachments/20170312/c8302760/attachment.sig>


More information about the neomutt-devel mailing list