[neomutt-devel] Unused functions

[Richard Russon]

I'm starting to tidy the code.
I've found 8 unused functions and 31 functions that should be static.

The winner is the prototype for crypt_smime_ask_for_key() which hasn't
existed for 13 years!

What should I do with the unused functions?

- leave them be
- comment them out
- delete them
- move them to obsolete.c
- something else

Rich

---

Unused functions:

    hash.c:223:       hash_set_data()
    muttlib.c:1966:   mutt_display_sanitize()
    muttlib.c:385:    mutt_dup_header()
    muttlib.c:431:    mutt_expand_link()
    mutt_socket.c:89: mutt_socket_read()
    pgp.c:103:        pgp_forget_passphrase()
    pgp.c:769:        pgp_extract_keys_from_messages()
    url.c:103:        url_parse_file()

Functions that should be static:

    compare_stat()
    crypt_smime_ask_for_key()
    km_bindkey()
    mbox_lock_mailbox()
    mbox_parse_mailbox()
    mbox_unlock_mailbox()
    menu_jump()
    mh_valid_message()
    mmdf_parse_mailbox()
    mutt_atol()
    mutt_bcache_move()
    mutt_gen_msgid()
    mutt_make_references()
    mutt_make_subj_hash()
    mutt_parse_references()
    mutt_randbuf()
    mutt_reopen_mailbox()
    mutt_sasl_get_callbacks()
    mutt_user_is_recipient()
    nntp_check_mailbox()
    nntp_fastclose_mailbox()
    nntp_fetch_message()
    nntp_open_mailbox()
    nntp_sync_mailbox()
    pgp_decrypt_part()
    pgp_fingerprint()
    pop_close_mailbox()
    pop_error()
    smime_ask_for_key()
    smime_free_key()
    state_putwc()

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://mailman.neomutt.org/pipermail/neomutt-devel-neomutt.org/attachments/20170312/dd12af05/attachment.sig>