[neomutt-devel] About C flavour (Was: Refactoring's cosmetics ?)

Guyzmo z+mutt+neomutt at m0g.net
Thu Jan 26 15:22:17 CET 2017


On Thu, Jan 26, 2017 at 03:03:17PM +0100, Pietro Cerutti wrote:
> >  - `#pragma once`,
> `#pragma once` is not standard (not even c11).

My bad, I thought it was, but it's a lovely thing <3

So would you be ok with them?

> >  - single line `//` comments,
> >  - stdbool/stdint, 
> >  - variable and flexible arrays,
> 
> I'd say no to VLAs, but I won't stress on that..

could elaborate why? I actually never used them, and I find the feature
quite lovely, if done right, especially in mutt's code base where you
have `buf[LONG_STRING]` declarations all over the place.

But on another hand, I'm still wondering whether it's just a front for a
hideous mess to put on the stack…

> >  - designated initialisers or
> >  - struct literals…
> > 
> > → Everybody agrees that we can, and should, use the most of C99
> >   features, to make new code elegant?
> Yes, I don't think anybody ever objected to this.

👍

(actually Rich told me to switch some single lines comments to /* */ in
patches I've pushed)

-- 
Guyzmo


More information about the neomutt-devel mailing list